Stefan Kost [Fri, 31 Jul 2009 07:26:34 +0000 (10:26 +0300)]
docs: fix include by adding GtkLabel-links doc to expand_content_files
Kristian Rietveld [Thu, 30 Jul 2009 19:23:47 +0000 (21:23 +0200)]
Bug 586374 – code does not follow documentation
Properly invalidate iterators in iter_next, iter_children,
iter_nth_child and iter_parent when FALSE is returned. ListStore was
actually already mostly in order as the GSequence pointers are very
strictly checked, but to be a little stricter we've added stamp = 0
lines. TreeStore did not invalidate its iterators, so stamp = 0 lines
were added where appropriate. Unit tests have been added to check this.
Fixes bug 586374, reported by Mike Gemunde.
Kristian Rietveld [Thu, 30 Jul 2009 18:22:45 +0000 (20:22 +0200)]
Bug 555109 – selection broken when typeahead active
gtk_tree_view_enter_notify() now "ignores" the synthesized crossing
events. The synthesized crossing events always have (0, 0) as
coordinates, which messes things up. This patch does not fix all issues,
at least it makes the behavior much more reasonable again. Watch bug
555109 for further discussion on the issue.
Kristian Rietveld [Thu, 30 Jul 2009 12:35:09 +0000 (14:35 +0200)]
Bug 573321 – additional check in gtk_tree_model_filter_convert_*
Added checks to see whether the passed iterators are not the same in
convert_child_iter_to_iter() and iter_to_child_iter() functions in both
the sort and filter models.
Fixes bug 573321, suggestion by Vadim Godunko.
Kristian Rietveld [Thu, 30 Jul 2009 12:17:00 +0000 (14:17 +0200)]
Bug 539377 – Unnecessary warnings when GtkTreeView is not realized
Adapt gtk_tree_view_get_path_at_pos() and
gtk_tree_view_get_drag_dest_row() to just return FALSE when bin_window
is NULL and not hit a warning. Makes this case consistent with the tree
view not having a model. Documentation has been updated to clarify
this, unit test has been added.
Fixes bug 539377, based on a patch by Bjorn Lindqvist.
Kristian Rietveld [Thu, 30 Jul 2009 11:58:25 +0000 (13:58 +0200)]
Bug 498010, 546005 - fix assertion in gtk_tree_view_set_cursor_on_cell
Instead of failing with warning on !tree_view->priv->tree, return
silently when tree_view->priv->model is NULL. Clarified in the
documentation that for invalid paths (and every path is invalid when no
model is set), the function will fail silently although the current
cursor will be unset.
Fixes bugs 498010 and 546005.
Kristian Rietveld [Thu, 30 Jul 2009 11:54:30 +0000 (13:54 +0200)]
Start general GtkTreeView unit tests
Includes a test case for bug 546005 to start with, logic provided by
Paul Pogonyshev and Bjorn Lindqvist. In the future, we should maybe
merge treeview-scrolling.c with this one to create one large monolithic
tree view tester.
Pascal Terjan [Tue, 28 Jul 2009 12:15:59 +0000 (14:15 +0200)]
Allow disabling New Folder button in File Choser
Bug #570516. Add a new property "create-folders" meaning that the
"New Folder" button should be displayed in the modes where it used
to be.
Matthias Clasen [Thu, 30 Jul 2009 13:07:37 +0000 (09:07 -0400)]
Correct a thinko
The xml way of saying %s is %s, not &s.
Emmanuele Bassi [Sat, 30 May 2009 11:43:28 +0000 (12:43 +0100)]
Bug #514260 – Better filtering for "Recently Used" files
Instead of refiltering the recently used files we should rebuild
the list altogether when the current GtkFileFilter changes; this
allows us to keep showing the maximum amount of recently used
files.
Fixes bug:
http://bugzilla.gnome.org/show_bug.cgi?id=514260
Emmanuele Bassi [Thu, 30 Jul 2009 10:10:45 +0000 (11:10 +0100)]
Fix gdk_window_get_cursor() documentation
The 'Return value' annotation is missing from the documentation
of gdk_window_get_cursor().
Emmanuele Bassi [Thu, 30 Jul 2009 10:10:22 +0000 (11:10 +0100)]
Add missing gdk_window_get_cursor to the GDK symbols
Kristian Rietveld [Thu, 30 Jul 2009 10:00:12 +0000 (12:00 +0200)]
Remove unused dirty iter discovery functions
gtk_tree_view_discover_dirty_iter() and gtk_tree_view_discover_iter()
have been in the tree forever, but unused since 1.3.8 or so. I guess we
no longer need them, so removed them. Fixes a compiler warning as well.
Michael Natterer [Thu, 30 Jul 2009 09:49:47 +0000 (11:49 +0200)]
Fix gtk_widget_get_allocation()
- add it to the header
- add the symbol to gtk.symbols
- fix coding style and check for allocation != NULL
Ivar Smolin [Thu, 30 Jul 2009 05:50:39 +0000 (08:50 +0300)]
Updating Estonian translation
Cody Russell [Thu, 16 Jul 2009 06:16:01 +0000 (01:16 -0500)]
add gdk_window_get_cursor()
Cody Russell [Thu, 30 Jul 2009 03:28:17 +0000 (22:28 -0500)]
add getter function for widget->allocation
Add gtk_widget_get_allocation() to retrieve a widget's allocation.
Needed as a step to enable GSEAL building.
This fixes bug #585211
Alejandro Piñeiro Iglesias [Wed, 29 Jul 2009 03:55:53 +0000 (11:55 +0800)]
Report ATK_STATE_SHOWING only when all parents are visible
Bug #509650. Checks if all the predecesors (the parent widget,
his parent, etc) are visible. Only reports ATK_STATE_SHOWING when
all parents are visible.
Signed-off-by: Li Yuan <li.yuan@sun.com>
Jamy [Tue, 28 Jul 2009 11:46:41 +0000 (13:46 +0200)]
Updated breton translation
Jamy [Tue, 28 Jul 2009 11:45:35 +0000 (13:45 +0200)]
Updated breton translation
Stefan Kost [Tue, 28 Jul 2009 08:21:49 +0000 (11:21 +0300)]
docs: add missing <variablelist> tags
Fixes docbook validation for these files.
Stefan Kost [Tue, 28 Jul 2009 08:20:22 +0000 (11:20 +0300)]
docs: inline see_also to sections docs and add missing <variablelist>
This fixes docbook validation for the file.
Federico Mena Quintero [Tue, 28 Jul 2009 00:24:42 +0000 (19:24 -0500)]
bgo#161489 - In the file chooser, let the left/right arrow keys switch focus between the file list and shortcuts
Based on a patch by Christian Neumair <cneumair@gnome.org>
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Mon, 27 Jul 2009 23:04:51 +0000 (18:04 -0500)]
From the shortcuts pane, focus the GtkEntry and redirect unhandled keystrokes to it
This lets us do this:
1. click on a folder in the shortcuts pane
2. start typing a filename
Then, the typed filename will actually go to the filename entry, like
the user expects. (Or to the search entry, in case the user clicked
on the Search shortcut.)
Also, removed the obsolete callback that made "/" and "~" typed in the
shortcuts pane bring up the location entry.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Federico Mena Quintero [Mon, 27 Jul 2009 22:21:28 +0000 (17:21 -0500)]
bgo#534462: Disable interactive search in the file chooser's shortcuts pane
People often do this:
1. Bring up a SAVE dialog
2. Click on a folder in the shortcuts pane
3. Start typing a filename
4. Oops! The interactive-search entry in the shortcuts pane appears.
With this, the shortcuts pane will not bring up the interactive-search entry. Then it
will be clear that you are not typing in the right place.
Signed-off-by: Federico Mena Quintero <federico@novell.com>
Daniel Nylander [Tue, 28 Jul 2009 00:22:30 +0000 (02:22 +0200)]
Updated Swedish translation
Cody Russell [Mon, 27 Jul 2009 20:39:28 +0000 (15:39 -0500)]
_gdk_window_impl_new() on directfb
Kjartan Maraas [Mon, 27 Jul 2009 14:36:56 +0000 (16:36 +0200)]
Fix translation
Hans Breuer [Sun, 26 Jul 2009 17:12:30 +0000 (19:12 +0200)]
Implement GdkDrawableImplWin32::draw_pixbuf
Hans Breuer [Sun, 26 Jul 2009 17:10:13 +0000 (19:10 +0200)]
Use G_DEFINE_TYPE (GdkDrawableImplWin32, ...)
Hans Breuer [Sun, 26 Jul 2009 17:08:49 +0000 (19:08 +0200)]
Some cursor work for csw(win32), more left to do
Hans Breuer [Sun, 26 Jul 2009 17:05:45 +0000 (19:05 +0200)]
Enable big_window bench on win32, dialog for everyone
Hans Breuer [Sat, 18 Jul 2009 14:24:02 +0000 (16:24 +0200)]
Formatting and removing commented/obsolete code
Philip Withnall [Sat, 25 Jul 2009 16:46:09 +0000 (17:46 +0100)]
Bug 589336 – Add GtkTreeViewColumn:sort-column-id property
Add the property, change notifications and documentation stubs.
Matthias Clasen [Sat, 25 Jul 2009 03:51:47 +0000 (23:51 -0400)]
Bump version
Matthias Clasen [Sat, 25 Jul 2009 03:49:37 +0000 (23:49 -0400)]
2.17.6
Matthias Clasen [Sat, 25 Jul 2009 02:52:21 +0000 (22:52 -0400)]
Updates
Alexander Larsson [Fri, 24 Jul 2009 19:41:37 +0000 (21:41 +0200)]
Fix cairo rendering on large subwindows
We get the real pixmap size and use as cairo surface size rather
than doing some magic to try to get clipping on the right hand size
(and the magic looks wrong anyway).
The previous code could result in the width/height being to big for
the cairo 28.4 fix point size and thus not drawing anything.
This fixes bug #588076.
Li Yuan [Fri, 24 Jul 2009 08:23:57 +0000 (16:23 +0800)]
Remove both SHOWING and SELECTED states when menuitem is not visible
Bug #582674 and Bug #574674. Remove SHOWING state also.
Li Yuan [Fri, 24 Jul 2009 08:11:30 +0000 (16:11 +0800)]
Remove ATK_STATE_SHOWING state when menuitem is not visible
When the menu is not selected, remove ATK_STATE_SHOWING state. And
emit state change signal if the menu is selected/unselected.
Matthias Clasen [Fri, 24 Jul 2009 04:45:34 +0000 (00:45 -0400)]
Fix issues with resize handles
The resize handles were not correctly redrawn and not positioned
correctly, initially.
Alexander Larsson [Thu, 23 Jul 2009 19:53:46 +0000 (21:53 +0200)]
Fix clipping of pixbuf drawing to windows
When the fallback for gdk_draw_pixbuf (gdk_drawable_real_draw_pixbuf)
is called with a window destination we have already applied any clip
regions and offsets for the window, but the window we get is a wrapper
and not an impl. We have to ensure we really draw to the impl, as
otherwise the pixbuf drawing will be clipped by client side subwindows.
This fixes bug 588553.
Alexander Larsson [Thu, 23 Jul 2009 19:52:32 +0000 (21:52 +0200)]
Avoid unnecessary indirect call
Call klass->draw_pixbuf directly inside gdk_window_draw_pixbuf
instead of gdk_draw_pixbuf to avoid doing all checks twice.
Ivar Smolin [Thu, 23 Jul 2009 16:08:44 +0000 (19:08 +0300)]
Updating Estonian translation
Daniel Nylander [Wed, 22 Jul 2009 12:23:31 +0000 (14:23 +0200)]
Updated Swedish translation
Daniel Nylander [Wed, 22 Jul 2009 11:51:09 +0000 (13:51 +0200)]
Updated Swedish translation
Tristan Van Berkom [Tue, 21 Jul 2009 16:48:39 +0000 (12:48 -0400)]
Slightly updated grammer in migrating-GtkBuilder.sgml
Just fixes the previous patch concerning using Glade if
possible before resorting to gtk-builder-convert to have
better grammer.
Javier Jardón [Mon, 20 Jul 2009 23:45:43 +0000 (01:45 +0200)]
Suggesto to use Glade instead gtk-builder-convert script (GnomeBug:587337)
* docs/reference/gtk/migrating-GtkBuilder.sgml
Cody Russell [Tue, 21 Jul 2009 16:44:25 +0000 (11:44 -0500)]
Bug 589275 – [csw] Trying to destroy NULL regions
gdk_window_input_shape_combine_mask() can accept NULL for the mask
parameter, but it wasn't checking for NULL before passing the
resulting GdkRegion to gdk_region_destroy(). Fixes #589275
Alexander Larsson [Mon, 20 Jul 2009 21:18:41 +0000 (23:18 +0200)]
Alexander Larsson [Mon, 20 Jul 2009 21:15:34 +0000 (23:15 +0200)]
Set clip region to empty for non-viewable windows
This lets us avoid lots of viewable checks and still not waste
time computing clip regions for non-viewable windows
Alexander Larsson [Mon, 20 Jul 2009 20:36:02 +0000 (22:36 +0200)]
Make gdk_window_begin/end_paint handle non-viewable windows
These are updated to not read clip region is not viewable
Alexander Larsson [Mon, 20 Jul 2009 20:30:48 +0000 (22:30 +0200)]
Make gdk_drawable_get_visible/clip_region handle the !viewable case
We can't access ->clip_region for these cases as its not yet calculated.
Alexander Larsson [Mon, 20 Jul 2009 20:19:35 +0000 (22:19 +0200)]
Calculate clip region when window goes viewable
Since we're no longer calculating clip regions for non-viewable windows
we need to calculate it when it goes viewable.
Jorge González [Mon, 20 Jul 2009 18:28:40 +0000 (20:28 +0200)]
Updated Spanish translation
Jorge González [Mon, 20 Jul 2009 18:27:43 +0000 (20:27 +0200)]
Updated Spanish translation
Jorge González [Mon, 20 Jul 2009 18:19:09 +0000 (20:19 +0200)]
Updated Spanish translation
Paolo Borelli [Sat, 18 Jul 2009 10:28:05 +0000 (12:28 +0200)]
Microoptimization in interactive search handling
Paolo Borelli [Sat, 18 Jul 2009 11:14:07 +0000 (13:14 +0200)]
Bug 588943 – set correct selection before emitting cursor-changed when searching
Make sure the correct selection is set when emitting cursor-changed
during an interactive search
Xan Lopez [Mon, 20 Jul 2009 06:58:22 +0000 (09:58 +0300)]
g_strdup_print does not exist, the function is g_strdup_printf.
Matthias Clasen [Mon, 20 Jul 2009 05:10:52 +0000 (01:10 -0400)]
Remove markup from translatable strings
Pointed out in bug 588964. String change !
Matthias Clasen [Mon, 20 Jul 2009 04:31:20 +0000 (00:31 -0400)]
Remove a duplicate include.
This was pointed out in bug 588897.
Matthias Clasen [Mon, 20 Jul 2009 03:46:53 +0000 (23:46 -0400)]
Fix a typo in the startup-id property definition
As well as some new GtkPrintOperation properties, which were not
correctly set up. This was noticed in bug 588958.
Matthias Clasen [Mon, 20 Jul 2009 03:21:52 +0000 (23:21 -0400)]
Add a translator comment
This fixes bug 589035.
Alexander Larsson [Sun, 19 Jul 2009 20:36:43 +0000 (22:36 +0200)]
Exit remove_child_area when region is empty
When the region is empty we can return early, because there
is no more area to remove. This happens often for children
of scrolled windows (i.e. things that are clipped out.
Alexander Larsson [Sun, 19 Jul 2009 20:35:25 +0000 (22:35 +0200)]
Optimize remove_child_area for children outside region
If a child is totally outside the current region, bail early instead
of doing costly calculations to subtract the child region.
Jorge González [Sun, 19 Jul 2009 16:45:41 +0000 (18:45 +0200)]
Updated Spanish translation
Theppitak Karoonboonyanan [Sun, 19 Jul 2009 06:02:49 +0000 (13:02 +0700)]
Updated Thai translation.
Alexander Larsson [Sat, 18 Jul 2009 19:56:03 +0000 (21:56 +0200)]
Fix read of non-initialized clip_region
Foreign children are always viewable but may not have a viewable
parent, so ensure we don't read the parent for them.
Alexander Larsson [Sat, 18 Jul 2009 19:55:17 +0000 (21:55 +0200)]
Don't read non-initialized clip region
The clip region is only initialized (and needed) for viewable windows.
Alexander Larsson [Sat, 18 Jul 2009 19:53:15 +0000 (21:53 +0200)]
Only handle viewable windows in collect_native_child_region
There is no need to handle non-viewable windows and additionally
they may not have the clip region set yet.
Alexander Larsson [Sat, 18 Jul 2009 19:51:11 +0000 (21:51 +0200)]
Only apply clip_region shape for viewable windows
This fixes a problem where the clip region is not yet calculated
Alexander Larsson [Sat, 18 Jul 2009 18:52:30 +0000 (20:52 +0200)]
Only calculate clipping regions for viewable windows
Alexander Larsson [Sat, 18 Jul 2009 18:37:19 +0000 (20:37 +0200)]
Check for viewable to avoid doing work instead of mapped
This is now cheap and allows us to avoid more work.
Alexander Larsson [Sat, 18 Jul 2009 18:29:50 +0000 (20:29 +0200)]
Track viewable for GdkWindow
Claude Paroz [Sat, 18 Jul 2009 18:45:09 +0000 (20:45 +0200)]
Updated French translation
Contributed by Laurent Coudeur and Claude Paroz.
Alexander Larsson [Sat, 18 Jul 2009 13:04:06 +0000 (15:04 +0200)]
GDK_WINDOW_TYPE does a runtime typecheck, don't call it unnecessary
Looking at a profile the typecheck from GDK_WINDOW_TYPE stood out quite
a bit, which is fixed by not using it unnecessarily.
Jorge González [Sat, 18 Jul 2009 12:40:07 +0000 (14:40 +0200)]
Updated Spanish translation
Jorge González [Sat, 18 Jul 2009 11:53:50 +0000 (13:53 +0200)]
Updated Spanish translation
Hans Breuer [Sat, 18 Jul 2009 11:31:51 +0000 (13:31 +0200)]
Use perl to make gtkalias.h without warnings
Hans Breuer [Sat, 18 Jul 2009 11:08:13 +0000 (13:08 +0200)]
Bug #588398 - Leak with testgtk::preview_(color|gray) and more
Revert to gdk_win32_ref_cairo_surface() implementation from gtk-2-16
and make _gdk_windowing_create_cairo_surface() simply delegate to it.
Matthias Clasen [Sat, 18 Jul 2009 03:11:12 +0000 (23:11 -0400)]
Bump version
Matthias Clasen [Sat, 18 Jul 2009 03:08:51 +0000 (23:08 -0400)]
2.17.5
Michael Natterer [Fri, 17 Jul 2009 19:49:58 +0000 (21:49 +0200)]
Two more getters for flags plus one new property
More stuff based on patches from Christian Dywan:
- gtk_widget_get_app_paintable()
- gtk_widget_get_double_buffered()
- r/w property "double-buffered"
Benjamin Otte [Fri, 10 Jul 2009 08:51:39 +0000 (10:51 +0200)]
Bug 588273 - Make number of validated rows depend on time, not row count
Previously, do_validate_rows() validated 300 rows per iteration. While
this is usually not problematic, as the typical tree view contains less
than 100 rows. Tree views with a lot of columns or complex cell
renderers could take inacceptably long, like:
- Epiphany's location bar entry completion has multiline and marked up
text in every cell. Validating a single row took ~1.5ms here.
- In the list view in Nautilus, When enabling all columns, validating a
single row would take ~3ms.
With 300 rows per iteration, that made those examples take 500ms/1s in a
signle main loop callback, and this obviously caused responsiveness
problems.
Now the code uses a timer and limits the time for validating rows to
30ms. This can cause less lines to be invalidated per call, so the
function might be called more often, but generally results in more
responsive applications.
Michael Natterer [Fri, 17 Jul 2009 19:18:26 +0000 (21:18 +0200)]
Add API for more widget flags
Add the following functions based on a patch from Christian Dywan:
- gtk_widget_set/get_can_focus()
- gtk_widget_set/get_can_default()
- gtk_widget_has_default()
Matthias Clasen [Fri, 17 Jul 2009 19:16:38 +0000 (15:16 -0400)]
Correct property types
Matthias Clasen [Fri, 17 Jul 2009 19:09:35 +0000 (15:09 -0400)]
Complete the get_buffer() conversion
There was one direct buffer access in gtk_entry_real_delete_text
leftover, and it promptly made our testsuite fail.
Matthias Clasen [Fri, 17 Jul 2009 18:31:00 +0000 (14:31 -0400)]
Updates
Matthias Clasen [Fri, 17 Jul 2009 17:29:07 +0000 (13:29 -0400)]
Fix DND onto an empty icon view
This did not work due to a copy and paste bug from the time when
the treeview DND code was turned into iconview DND code. Fixes
bug 599484.
Hans Breuer [Fri, 17 Jul 2009 12:26:02 +0000 (14:26 +0200)]
More efficient version of _gdk_win32_window_queue_translation()
Don't create create an extraneous expose event for any scroll operation
that gtk+ does. Thanks to Alex for the hint.
Hans Breuer [Fri, 17 Jul 2009 12:38:43 +0000 (14:38 +0200)]
Fix inconsistent line-endings
They are causing trouble with core.autocrlf=true, see:
http://mail.gnome.org/archives/gtk-devel-list/2009-July/msg00041.html
Marek Kasik [Fri, 17 Jul 2009 14:33:16 +0000 (16:33 +0200)]
Change position of paper's dimensions according to reading direction
Change position of paper's dimensions in GtkPrintUnixDialog according
to reading direction.
Tristan Van Berkom [Fri, 17 Jul 2009 03:19:03 +0000 (23:19 -0400)]
Fixed crashes when GtkEntry's internal buffer is not available (bug 588395)
To fix this I replaced the code that creates an internal buffer
at init and construction time with code that creates a buffer
at _get_buffer() time, this is the same as GtkTextView does and
fixes the crashes for me.
Matthias Clasen [Fri, 17 Jul 2009 02:06:40 +0000 (22:06 -0400)]
Make suitable GtkAssistant buttons default
We grab the default to the apply, forward or close buttons, as
appropriate. Also, make sure that the logic for setting the focus
to the best place on page change is applied to the initial page.
Matthias Clasen [Fri, 17 Jul 2009 00:54:42 +0000 (20:54 -0400)]
Make jasper support optional
To enable it, one must now pass --with-libjasper to configure.
Tor Lillqvist [Thu, 16 Jul 2009 19:03:33 +0000 (22:03 +0300)]
Disable the GDI+ loaders by default as they are broken.
André Gondim [Thu, 16 Jul 2009 00:31:37 +0000 (21:31 -0300)]
Updated Brazilian Portuguese translation.
Matthias Clasen [Wed, 15 Jul 2009 23:17:36 +0000 (19:17 -0400)]
Add a tooltip to the save folder combo
Add a tooltip that shows the full path of the current folder, to avoid
ambiguity. We only show the tooltip when the expander is collapsed to
avoid cluttering the full file chooser.
Matthias Clasen [Wed, 15 Jul 2009 22:29:13 +0000 (18:29 -0400)]
Use G_CONST_RETURN for const return values